Fix the handling of file descriptors when new connections fd are in the 0~MAX_PASS_FD range #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s here, if they are open dup2() will close them before copy the new file descriptor. This fixes part of the bug where a valid file descriptor in this range is closed before the child is runs (easily reproductible with a single UDP service). Obtained from: pfSense
…FD range as in this case it will also close the copied file descriptor (dup2() does nothing when src == dst). This fixes the other part of the bug where a valid file descriptor in this range is closed before the child is runs (easily reproductible with a single UDP service). Obtained from: pfSense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211038
https://redmine.pfsense.org/issues/6315
This happens because the UDP service was using the 0 (zero) file descriptor for the (new) received connection (which was later closed before it could be used by the child).
This is easily reproducible by setting a single UDP service in xinted.