Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Chinese translations for doc pages #250

Merged
merged 3 commits into from
Nov 23, 2024
Merged

feat: add Chinese translations for doc pages #250

merged 3 commits into from
Nov 23, 2024

Conversation

Crepveant
Copy link
Contributor

Closes: #246

@Crepveant Crepveant requested a review from xicri as a code owner November 23, 2024 11:02
xicri
xicri requested changes Nov 23, 2024
View reviewed changes
Copy link
Owner

@xicri xicri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Looks good except for capitalization issue of HoYo"v"erse.

pages/about.vue Outdated Show resolved Hide resolved
pages/opendata.vue Outdated Show resolved Hide resolved
@xicri xicri added the docs Improvements or additions to documentation label Nov 23, 2024
@xicri
Copy link
Owner

xicri commented Nov 23, 2024

Ignore failure of vrt action. It was caused by the lack of the secret for the PR by the "external" contributors.

@xicri xicri changed the title feat: Add Chinese i18n support feat: add Chinese translations for doc pages Nov 23, 2024
@xicri xicri enabled auto-merge (rebase) November 23, 2024 13:56
@xicri xicri disabled auto-merge November 23, 2024 13:57
@xicri xicri enabled auto-merge (squash) November 23, 2024 13:58
@xicri
Copy link
Owner

xicri commented Nov 23, 2024

I will merge this PR as soon as the automated tests succeeded.

@xicri xicri disabled auto-merge November 23, 2024 22:36
@xicri xicri enabled auto-merge (squash) November 23, 2024 22:37
@xicri xicri disabled auto-merge November 23, 2024 22:40
@xicri xicri merged commit e9da37a into xicri:main Nov 23, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xicri xicri xicri approved these changes

Assignees

@Crepveant Crepveant

Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate /about & /opendata to Chinese
2 participants
@Crepveant @xicri