Skip to content

Commit

Permalink
return empty string upon failed client lookup
Browse files Browse the repository at this point in the history
  • Loading branch information
Ravi Nagarjun Akella authored and Ravi Nagarjun Akella committed Sep 9, 2024
1 parent 7100c80 commit b7eca90
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class HomestoreConan(ConanFile):
name = "homestore"
version = "6.4.56"
version = "6.4.57"

homepage = "https://github.com/eBay/Homestore"
description = "HomeStore Storage Engine"
Expand Down
4 changes: 3 additions & 1 deletion src/lib/replication/repl_dev/raft_repl_dev.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1092,7 +1092,7 @@ void RaftReplDev::flush_durable_commit_lsn() {
}

/////////////////////////////////// Private metohds ////////////////////////////////////
void RaftReplDev::cp_flush(CP*) {
void RaftReplDev::cp_flush(CP* cp) {
auto const lsn = m_commit_upto_lsn.load();
auto const clsn = m_compact_lsn.load();

Expand All @@ -1108,6 +1108,8 @@ void RaftReplDev::cp_flush(CP*) {
m_rd_sb->last_applied_dsn = m_next_dsn.load();
m_rd_sb.write();
m_last_flushed_commit_lsn = lsn;
RD_LOGD("cp flush in raft repl dev, lsn={}, clsn={}, next_dsn={}, cp string:{}", lsn, clsn, m_next_dsn.load(),
cp->to_string());
}

void RaftReplDev::cp_cleanup(CP*) {}
Expand Down
1 change: 1 addition & 0 deletions src/lib/replication/service/raft_repl_service.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ RaftReplDev* RaftReplService::raft_group_config_found(sisl::byte_view const& buf

std::string RaftReplService::lookup_peer(nuraft_mesg::peer_id_t const& peer) {
auto const p = m_repl_app->lookup_peer(peer);
if (p.first.empty()) { return {}; }
return p.first + ":" + std::to_string(p.second);
}

Expand Down

0 comments on commit b7eca90

Please sign in to comment.