Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCKER-450 [Add] Support for Alfresco v23.1 && v23.2 #208

Merged
merged 4 commits into from
Jun 10, 2024
Merged

DOCKER-450 [Add] Support for Alfresco v23.1 && v23.2 #208

merged 4 commits into from
Jun 10, 2024

Conversation

codingBenVdS
Copy link
Contributor

@codingBenVdS codingBenVdS commented Apr 26, 2024 •
edited
Loading

DOCKER-450 [Add] Support for Alfresco v23.1 && v23.2

  • [Add] tomcat-embedded V10
  • [TODO] Add postgres V15 ?
  • [Sonarqube] ignored TomcatFactory.java from sonarqube. Duplicate code and 0% test issues due to code being seperated from tomcat-base source-code. (can be removed after Alfresco V7.X is dropped)
    Ticket: https://xenitsupport.jira.com/browse/DOCKER-450

@codingBenVdS codingBenVdS force-pushed the DOCKER-450 branch 3 times, most recently from 84166d8 to 8c28283 Compare May 24, 2024 14:42
@codingBenVdS
DOCKER-450 [Add] Support for Alfresco v23.1 && v23.2
ea117c8 
  * [Add] tomcat-embedded V10
  * [Update] JSON-logging V0.0.7 to V0.0.8
  * [Update] Changelog
  * [source] https://docs.alfresco.com/content-services/latest/support/#supported-platforms/23-1

DOCKER-450 [test] sonarcube

DOCKER-450 [test] ignore subproject embedded-x code for sonarqube
@codingBenVdS
DOCKER-450 [Ignore] tomcate-base:tomcat-embedded-X code for review.
d1425b8 
  * Normally this code belongs with the tomcat-base code and does not trigger issues.
  * TomcatFactory.java can be set back into tomcat-base as soon as Alfresco V7.X is dropped.
thijslemmens
thijslemmens requested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@thijslemmens thijslemmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the official PostgreSQL images. Remove the Jackson dependency now it is bundled in our logging library

@codingBenVdS codingBenVdS requested a review from thijslemmens May 31, 2024 09:33
thijslemmens
thijslemmens requested changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@thijslemmens thijslemmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you need 3 versions of TomcatFactory now, we only used one in the passed. You should at most have 2?

tomcat-base/build.gradle Outdated Show resolved Hide resolved
@codingBenVdS codingBenVdS requested a review from thijslemmens June 6, 2024 07:19
@codingBenVdS codingBenVdS merged commit 781fb61 into master Jun 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijslemmens thijslemmens thijslemmens approved these changes

@RVanhuysseXenit RVanhuysseXenit Awaiting requested review from RVanhuysseXenit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codingBenVdS @thijslemmens