XENOPS-1201 Cleanup ; Added Alfresco 7.x; Dropped Alfresco 7.0 and lower #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
todorinskiz
commented
Dec 20, 2024
todorinskiz
commented
- Dropped Alfresco 5 and 6
- Added Alfresco 7.1, 7.2, 7.3, 7.4
- Dropped secret in favor of TLS
- Dropped obsolete Jar shadowing
- Dropped obsolete boms
- Fixed log4j2 bug (limited to docker compose and minimal log4j2.properties config)
- Fixed bug in integration test where files used for testing were no longer available
todorinskiz
requested review from
vierbergenlars,
RVanhuysseXenit,
kpiot123,
Brobrechts and
maartenboonen-xenit
todorinskiz
commented
Dec 20, 2024
| extendsFrom(internalPlatform) | ||
| } | ||
| } | ||
| //description = "Alfresco Repository module for ${rootProject.description}" |
There was a problem hiding this comment.
I don't understand why, but gradle couldn't add module.properties when the descriptions were set. Some bug in Alfresco Gradle SDK?
There was a problem hiding this comment.
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':alfresco-health-processor-platform:testAmp'.
Caused by: org.gradle.api.GradleException: Could not add file '/git/xenit/alfresco-health-processor/alfresco-health-processor-platform/build/processTestModuleProperties/module.properties' to ZIP '/git/xenit/alfresco-health-processor/alfresco-health-processor-platform/build/dist/alfresco-health-processor-platform-0.5.7-SNAPSHOT-test.amp'.
Caused by: groovy.lang.GroovyRuntimeException: Failed to parse template script (your template may contain an error or be trying to use expressions not currently supported): startup failed:
SimpleTemplateScript4.groovy: 1: Unexpected character: '"' @ line 1, column 13.
out.print("""module.description=Alfresco Repository module for Alfresco Health Processor\: A background processor capable of performing various operations on the nodes in your Alfresco repository, in a batched and controlled manner
30310ee to
68245a0
Compare
….4; Dropped secret in favor of TLS; Dropped obsolete Jar shadowing; Dropped obsolete boms; Fixed log4j2 bug (limited to docker compose and minimal log4j2.properties config; Fixed bug in integration test where files used for testing were no longer available;
todorinskiz
force-pushed
the
XENOPS-1201
branch
from
68245a0 to
c64cc51
Compare
pvriel
reviewed
Jan 6, 2025
|
|
||
| javax.net.ssl.SSLContext sslContext = SSLContexts.custom() | ||
| .loadKeyMaterial(keyStore, keyPasswordChars) | ||
| .loadTrustMaterial(trustStore, (chain, authType) -> true) // Use default trust strategy |
There was a problem hiding this comment.
Is this really what this code is supposed to do? This is unsafe.
There was a problem hiding this comment.
Could you change "Use default trust strategy" to "Accept any certificate" here?
pvriel
approved these changes
Jan 6, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.