Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place admin webscript in main context #59

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

vierbergenlars
Copy link
Member

Webscripts should be part of the main context, so the bean is not recreated when the subsystem is restarted.

If the webscript bean is recreated; it would be uninitialized, which results in problems with the webscript registry and the admin console (e.g. NullPointerException when trying to access the webscript)

Old versions of reckon were published to jcenter and are no longer available
Webscripts should be part of the main context, so the bean is
not recreated when the subsystem is restarted.

If the webscript bean is recreated; it would be uninitialized, which
results in problems with the webscript registry and the admin console
(e.g. NullPointerException when trying to access the webscript)
This is necessary to support docker compose v2
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@vierbergenlars vierbergenlars merged commit fafaefd into master Dec 16, 2024
10 of 11 checks passed
@vierbergenlars vierbergenlars deleted the fix-webscript-reference branch December 16, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants