Backport 5.x/testing imporvements #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WimCrols
requested changes
Dec 19, 2024
| @@ -2,7 +2,7 @@ version: '2' | |||
|
|
|||
| services: | |||
| alfresco-core: | |||
| image: ${DOCKER_IMAGE} | |||
| image: ${DOCKER_IMAGE:-private.docker.xenit.eu/alfresco-enterprise/alfresco-repository-enterprise:7.0} | |||
There was a problem hiding this comment.
These defaults can lead to silent failures when the image is not built. I prefer to keep them out.
| @@ -23,6 +23,7 @@ ext { | |||
| jackson_version = '2.8.3' | |||
| care4alfVersion = '2.3.0' | |||
| http_version = '4.3.4' // Used by integration tests | |||
| ootbee_version = '1.2.2.0' // Used in docker image for testing | |||
There was a problem hiding this comment.
Since this is only used once, why not keep it locally, close to where it is used? It makes development easier since there is less switching needed.
| AuthenticationUtil.runAsSystem( | ||
| () -> transactionHelper.doInTransaction( | ||
| () -> { | ||
| NodeRef companyHome = nodeLocator.getNode(CompanyHomeNodeLocator.NAME, null, null); |
There was a problem hiding this comment.
Be aware there is also https://github.com/xenit-eu/alfred-api/blob/master/alfred-api-integrationtests-client/alfresco/src/main/java/eu/xenit/alfred/api/tests/JavaApiBaseTest.java#L53 which may overlap? Non-blocking...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing improvements made for https://xenitsupport.jira.com/browse/ALFREDAPI-566
Breaking changes include adding, changing or removing endpoints and/or JSON objects used in requests and responses.
@ExceptionHandlerin the webscript classes?this.prefix avoided?See README.md for full explanation.