Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALFREDAPI-562 #235

Merged
merged 14 commits into from
Dec 16, 2024
Merged

ALFREDAPI-562 #235

merged 14 commits into from
Dec 16, 2024

Conversation

WimCrols
Copy link
Collaborator

@WimCrols WimCrols commented Dec 10, 2024

Fixes https://xenitsupport.jira.com/browse/ALFREDAPI-562

  • Is CHANGELOG.md extended?
  • Does this PR avoid breaking the API?
    Breaking changes include adding, changing or removing endpoints and/or JSON objects used in requests and responses.
  • Does the PR comply to REST HTTP result codes policy outlined in the user guide?
  • Is error handling done through a method annotated with @ExceptionHandler in the webscript classes?
  • Does the PR follow our coding styleguide and other active procedures?
  • Is usage of this. prefix avoided?

See README.md for full explanation.

@WimCrols WimCrols marked this pull request as draft December 10, 2024 13:39
@WimCrols WimCrols force-pushed the ALFREDAPI-562_lowlvl branch 3 times, most recently from 79c864c to f4eb2c9 Compare December 10, 2024 13:53
@WimCrols WimCrols force-pushed the ALFREDAPI-562_lowlvl branch from f4eb2c9 to 041fae3 Compare December 10, 2024 13:54
@WimCrols WimCrols marked this pull request as ready for review December 12, 2024 14:48
Copy link

Copy link
Contributor

@codingBenVdS codingBenVdS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@WimCrols WimCrols merged commit f09e0cf into master Dec 16, 2024
7 checks passed
@WimCrols WimCrols deleted the ALFREDAPI-562_lowlvl branch December 16, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants