Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alfredapi 541/installdeps #199

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Alfredapi 541/installdeps #199

merged 4 commits into from
Feb 21, 2024

Conversation

WimCrols
Copy link
Collaborator

@WimCrols WimCrols commented Feb 21, 2024

Fixes https://xenitsupport.jira.com/browse/ALFREDAPI-541

  • Is CHANGELOG.md extended?
  • Does this PR avoid breaking the API?
    Breaking changes include adding, changing or removing endpoints and/or JSON objects used in requests and responses.
  • Does the PR comply to REST HTTP result codes policy outlined in the user guide?
  • Is error handling done through a method annotated with @ExceptionHandler in the webscript classes?
  • Does the PR follow our coding styleguide and other active procedures?
  • Is usage of this. prefix avoided?

See README.md for full explanation.

Copy link

@Brobrechts Brobrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good,
However when I try to render the file locally I get some API errors,
docker run -p 8888:8080 swaggerapi/swagger-editor

Not sure if this is due to the pretty-print or if this was always the case?
Looking into it still

Copy link

@Brobrechts Brobrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved,

Please consider opening a new ticket for the openapi specification warnings/errors

@WimCrols WimCrols merged commit b6763ff into master Feb 21, 2024
11 checks passed
@WimCrols WimCrols deleted the ALFREDAPI-541/installdeps branch February 21, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants