UI: Improve user experience when AV Pack is set to "None"

[Fabxx]

Fixes #1186

test.mp4

[GXTX]

There's nothing inherently wrong with warning users about this, however I think a better approach would be to remove the option from the UI. Having no avpack connected is not beneficial to any end user and is only useful to a developer testing how the kernel and software react to that situation. People who need this functionality can already do this via command line launch options and via config.

[halotroop2288]

not beneficial to any end user

I counter that it would make blindfolded playthroughs more authentic! 😸
And editing a config by hand is just bad UX, I think this is better.

[antangelo]

I would prefer that we keep the option in the UI, I agree that having it there is better UX than requiring a command line argument even for developer use. As an alternative, we can add a warning above or below the setting in the UI if None is selected that indicates there will not be any video output, which should be clear enough on that front (in addition to the changing of the uninitialized display text).

[dracc]

not beneficial to any end user

I counter that it would make blindfolded playthroughs more authentic! 😸 And editing a config by hand is just bad UX, I think this is better.

Current implementation doesn't just disable video output, but emulates what happens if you haven't connected the AV Pack. What happens is the front LEDs flash orange and green and execution stops - not at all helpful for speedrunning.

[mborgerson]

I agree a better default uninitialized screen would be nice, but I think we can do better than more console text here. How about just warning on the settings page when None is selected

[halotroop2288]

Did you just revert the whole PR?

[Fabxx]

Main code has been updated

[Fabxx]

all the modifications were applied, should be ready to merge

[mborgerson]

Thanks!