Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty fingerprints (upstream upgrade bug) #76

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

stormi
Copy link
Member

@stormi stormi commented Aug 30, 2024

  • Add xapi-24.19.2-update-new-fingerprint-fields-on-DB-upgrade.backport.patch, backported from XAPI project
  • Add xapi-24.19.2-more-fingerprint-field-updates-fixes.XCP-ng.patch to complement the fix
  • Fixes an issue where new fingerprint fields are not populated, which under some circumstances makes pool join fail.

See xapi-project/xen-api#5955

The second patch was written by psafont and hasn't been tested at XenServer yet. I've built it and tested it, and it solved the issues I was seeing, but it still needs a careful review.

- Add xapi-24.19.2-update-new-fingerprint-fields-on-DB-upgrade.backport.patch, backported from XAPI project
- Add xapi-24.19.2-more-fingerprint-field-updates-fixes.XCP-ng.patch to complement the fix
- Fixes an issue where new fingerprint fields are not populated, which under
  some circumstances makes pool join fail.

Signed-off-by: Samuel Verschelde <[email protected]>
Copy link
Contributor

@benjamreis benjamreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stormi stormi merged commit 13db72b into master Sep 3, 2024
1 check passed
@stormi stormi deleted the stormi/fix-fingerprint-field branch September 3, 2024 07:35
@stormi
Copy link
Member Author

stormi commented Sep 3, 2024

Koji build to v8.3-incoming: https://koji.xcp-ng.org/buildinfo?buildID=3484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants