Adds setting "Unpack compressed" #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ressed archives are unpacked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it is set to false, then no compressed archives are unpacked and the addon only deals with non-compressed rar archives (method "Store").
What I'm trying to solve
Me and many other have experienced issues using Kodi with rar'ed movies since Kodi v18 or v19. One example is issue #102 which describes experiences similar to mine. It seems to work, but it can't be used because it is unpacking compressed archives and keep asking about the same files every library scan.
How I'm trying to solve it
I've added a setting to enable unpacking of compressed files. It is on by default, to not change the current behaviour. To solve the issues caused by unpacking compressed files one disables the setting.
I'm new to Kodi development and C++. If my edits aren't working the way I intended I'd be very happy to get some advice.