-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fonts to related language addons #190
base: nexus
Are you sure you want to change the base?
Conversation
About the other fonts I created:
Because of the "resource.font.active" has to be kept under observation a little (if moved to Kodi), if the associated language comes in here, it would have to be moved from there to here. |
How will this work when skins provide the fonts? |
The skin is always as primary, only in case the wanted character becomes not found there, does it a fallback to this ones on language addons. See on https://github.com/AlwinEsch/kodi/blob/fix-estuary-strings/xbmc/guilib/GUIFontTTF.cpp#L1231-L1233 |
@AlwinEsch That sounds really great. |
77cb41c
to
c8782e8
Compare
Is updated and also added on second commit, additional font addons to allow Kodi in his use case the availability. |
c8782e8
to
ac5d3cd
Compare
ac5d3cd
to
c8d480e
Compare
@@ -6,6 +6,7 @@ | |||
provider-name="Team Kodi"> | |||
<requires> | |||
<import addon="kodi.resource" version="1.0.0"/> | |||
<import addon="resource.language.zh_cn" version="9.0.0"/> <!-- To get his font file about where support all --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added new to get on zh_tw
and ja_jp
the font file from zh_cn
where contains mostly all.
Bad is that on NotoSansJP-Regular.ttf and NotoSansTC-Regular.ttf also some where not on other, thats why also inside here another one.
@AlwinEsch What is required for this PR to get merged? |
This adds some TTF files in order to have the corresponding character type for upcoming changes in Kodi in the respective language. The background is that Kodi does not support the characters in very many languages and could only be fixed in a few using "Arial.ttf". Think about relocating it here, as it is needed in the respective language and so as not to flood Kodi when everyone was in it.
c8d480e
to
0afc89d
Compare
With here are 3 font addons added: - resource.font.active Fonts to active used characters - resource.font.excluded Fonts to no more active charactes on world - resource.font.limited Fonts to active, but with less usage - resource.font.coloremoji Font about colored emoji's
0afc89d
to
857fe4d
Compare
How we see the state about this? Maybe we can bring in and have ready for the request in Kodi? @gade01 It can be come in before. The fonts inside here, then currently not used, but prepared for the request in Kodi (xbmc/xbmc#20552) |
It looks great to me, but perhaps I'm not the right person to review this. :) |
@AlwinEsch please check addon-checker errors, it looks like the icons you specify on addon.xml do not exist. |
I tested these for the CJK variants back when the core PR was fresh and the language resources did work as expected. Not sure anything gained by splitting out the fonts as the way the fonts are designed is language-specific. Unless a skin/addon provides complete coverage in a skin-provided font, then the language font is not needed. I think xbmc/xbmc#20552 needs a rebase to really test this again? |
About the reason to combine the font with language is mainly to have on language switch immediately the needed font available, without it can come that the language is switched and user becomes asked for font and not readable then. I make on next days a rebase about the font pull requests and to become ready for use. |
Description
This adds some TTF files in order to have the corresponding character type for upcoming changes in Kodi in the respective language.
The background is that Kodi does not support the characters in very many languages and could only be fixed in a few using "Arial.ttf".
Think about relocating it here, as it is needed in the respective language and so as not to flood Kodi when everyone was in it.
Checklist:
Additional information :