-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RightSidebar Kodi icon and hover effect on progress slider #79
Added RightSidebar Kodi icon and hover effect on progress slider #79
Conversation
src/Components/RightSidebar.elm
Outdated
Element.row [] | ||
[ image [ width (px 15), height (px 15), paddingXY 15 0 ] | ||
{ description = "" | ||
, src = "https://raw.githubusercontent.com/ionif/elm-chorus/master/logo.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be a local image in the end. Chorus will have to work fine when your offline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @razzeee ,
I have made changes to the code, now the images which is being used in the rightsidebar is local.
Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
@razzeee , |
This should be a dev dependency, not a dependency. It also seems to be a parcel 1 plugin, but we're using parcel 2 |
Hi @razzeee, |
This is conflicting now, you probably need to rebase |
…ckage Crebase from master B
Hi @razzeee, |
I don't think you did that correctly :) |
Hi @razzeee ,
I have added Kodi icon to the RightSidebar and hover effect on the progress slider like in Chorus-2.