Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RightSidebar Kodi icon and hover effect on progress slider #79

Conversation

developingright
Copy link
Contributor

@developingright developingright commented Apr 2, 2022

Hi @razzeee ,
I have added Kodi icon to the RightSidebar and hover effect on the progress slider like in Chorus-2.

Name RideSidebar Kodi button Progress Slider
Chorus-2 Screenshot from 2022-04-02 14-50-39 Screenshot from 2022-04-02 14-59-54

Name Before making changes After making changes
Elm-chorus -> RightSidebar Kodi button 161093468-caf63bb8-6d88-42d6-9b6a-e405bcc38f67 (1) Screenshot from 2022-04-02 14-52-23
Elm-Chorus -> Progress Slider Screenshot from 2022-04-02 15-05-56 Screenshot from 2022-04-02 15-08-02

Element.row []
[ image [ width (px 15), height (px 15), paddingXY 15 0 ]
{ description = ""
, src = "https://raw.githubusercontent.com/ionif/elm-chorus/master/logo.png"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be a local image in the end. Chorus will have to work fine when your offline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @razzeee ,
I have made changes to the code, now the images which is being used in the rightsidebar is local.

@developingright
Copy link
Contributor Author

@razzeee ,
Since Elm doesn’t support autoloading, one way to achieve this was to use the development server to serve the static files (for ex: “http:localhost:1234/images/logo.png” as image src). Since we are using parcel for running the development server, I have installed a parcel plugin “parcel-plugin-static-files-copy” and created an image folder in public folder which is mapped to the server. Now, I will create a PR to make all of the static files link local which is an already existing issue.

@razzeee
Copy link
Member

razzeee commented Apr 25, 2022

This should be a dev dependency, not a dependency.

It also seems to be a parcel 1 plugin, but we're using parcel 2

@developingright
Copy link
Contributor Author

Hi @razzeee,
I have updated the package.json file and updated the plugin which uses parcel2 “parcel-reporter-static-files-copy” for serving the static files.

@razzeee
Copy link
Member

razzeee commented Apr 28, 2022

This is conflicting now, you probably need to rebase

@developingright
Copy link
Contributor Author

Hi @razzeee,
I have rebased the code and resolved the conflicts.

@razzeee
Copy link
Member

razzeee commented May 2, 2022

I don't think you did that correctly :)
There are a bunch of unrelated commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants