Implemented Tvshowid_int page

[developingright]

Hi @razzeee,
I have created and implemented the tvshowid_int page which contains the information about a particular tvShow. I have worked on its routing, created a SeasonObj, modified decoders, created new decoders from scratch, and implemented the viewSeason card for the SeasonObj. Please let me know if any changes are required.

Chorus 2	Elm Chorus

[razzeee]

Hrm, I can't get through the tvshow/movie list pages. It shows no movies/tvshows for me.

The console log shows that it's receiving data. But movie_list / tvshow_list is empty, not sure if my library is just too big or if my data is different, as I might be using a different scrapper?

[developingright]

Hi @razzeee,
I think if it’s working fine with Chorus 2 then it should also work with Elm Chorus. I am using TMDb Tv Shows and TMDb Movie Scrapper. I wonder if you are able to get a list of all tvShows/Movies in return if you make a JSON RPC request from Kodi/labs/API-browser in Chorus 2.

[razzeee]

I'm not near a pc to test that in the next 5 days

[razzeee]

http://localhost:8080/#lab/api-browser/VideoLibrary.GetMovies for e.g. returns fine on chorus 2 and it seems to work in the frontend too. while it breaks for elm-chorus.

I haven't replicated that for tvshows, but will do soon.

[razzeee]

The poster should be clickable in the overview too

[razzeee]

• Image on the right doesn't fade
• Long texts do not get truncated. The old chorus had a section that could be extended.

[developingright]

@razzeee, It should be clickable, like here in this screenshot, I wonder what could be causing it to not work. Also, the image on the right fades in Chrome and other supported browsers except for Mozilla, etc. the mask-image property isn't supported in Mozilla Firefox. I will make the other changes ASAP.

The poster should be clickable in the overview too

[razzeee]

We need something that works in firefox, as that should be the browser we target. As it's the only OSS engine.

[razzeee]

To be clear this is the view, where I can't click the poster images. I need to click on the show title to get to the detail page.

[developingright]

Hi @razzeee,
Since this change is related to card UI, I was thinking that creating a separate PR to make posters clickable and resolving the issue "truncate the items" for the cards will be better.

In addition, regarding the image fade effect not working in Firefox, I was thinking of fixing UI irregularities and CSS bugs in the end once pages and functionalities have been implemented.

It would be great if you could share your thoughts on this.

[razzeee]

First one makes sense.

I'm not so sure about the second one, but if you would like that that's fine. But will make it harder for me to test.

[developingright]

It should not make it hard for you to test as I will make sure to mention the changes I have made and the bugs / irregularities that I have fixed. 🙂

First one makes sense.

I'm not so sure about the second one, but if you would like that that's fine. But will make it harder for me to test.

[developingright]

Hi @razzeee,
I have made the required change.

on click ->

[razzeee]

I'm wondering if we should be using a background-image like the old design as the new one seems to be using an img tag.

New

Old

They also seem to handle the rating differently (maybe it's rounding differently?)

[razzeee]

Studio and Cast should also switch order

[developingright]

Hi @razzeee,
I have fixed the typo in the TvShow Obj, and switched the order of cast and studio details. The rating was rendered on the front-end exactly how its value was unlike Chorus 2 which rounds the values. Now, it's working the same.

Also, about whether we should use background-image or img, I think it should be fine with img tag as the convention which is normally followed is that if the same image is used at multiple places its better to use background-image but in our case, we are fetching the fanart every time as it's different for every other object.

[razzeee]

We stll need to fix the image sizing then.

[developingright]

Hi @razzeee,
This issue can be considered a UI irregularity and as I suggested earlier, I was thinking of addressing these issues once the pages and functionalities have been implemented, in a separate PR. Please let me know if it’s fine with you. 🙂