Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Version Drivers #6163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lindig
Copy link
Contributor

@lindig lindig commented Dec 6, 2024

MVD CP-52334 multi-version driver API/CLI

Provide an API/CLI for multi-version drivers. Two new classes represent
them: Host_driver and Driver_variant. See

  * doc/content/toolstack/features/MVD/index.md

for technical background and feature overview.

The current implementation mocks the missing drivertool that manipulates
the file system and observes driver state. We expect to integrate this
at a later point. Consequently, the current implementation is incomplete
and exists to faciliate development of API and XE clients.

On Xapi start and restart driver information is purged from the
database and re-built from scrach. This could be improved in the future
to be incremental.

quality-gate.sh Fixed Show fixed Hide fixed
@lindig lindig marked this pull request as ready for review December 9, 2024 13:18
@lindig lindig force-pushed the private/christianlin/multi-driver-v2 branch from 36118b3 to 6d992d8 Compare December 9, 2024 16:10
Provide an API/CLI for multi-version drivers. Two new classes represent
them: Host_driver and Driver_variant. See

  * doc/content/toolstack/features/MVD/index.md

for technical background and feature overview.

The current implementation mocks the missing drivertool that manipulates
the file system and observes driver state. We expect to integrate this
at a later point. Consequently, the current implementation is incomplete
and exists to faciliate development of API and XE clients.

On Xapi start and restart driver information is purged from the
database and re-built from scrach. This could be improved in the future
to be incremental.

Signed-off-by: Christian Lindig <[email protected]>
@lindig lindig force-pushed the private/christianlin/multi-driver-v2 branch from 6d992d8 to f0db7d8 Compare December 9, 2024 16:16
@Vincent-lau
Copy link
Contributor

I understand this is a draft version. But would be easier to split it into smaller commits for review, or is that not very feasible?

@lindig
Copy link
Contributor Author

lindig commented Dec 10, 2024

I worked from the original work by @last-genius but ended up having so many changes that the commit history was not meaningful. In addition, re-basing made a mess of them. In the end, this is difficult to split up - it's almost impossible to split this up such that each commit still compiles because it references each other. I could split it by module or something like it - but that is not entirely logical either.

@lindig
Copy link
Contributor Author

lindig commented Dec 12, 2024

I have additional code to make the database update incremental on scan() but would like to see the basics reviewed first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants