Xapi thread classification - part 2 #6154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds more granurality in the xapi thread classification. Now, an
individual thread can be mapped to the following:
- {xapi_cgroup}/internal/SM;
- {xapi_cgroup}/internal/cli;
- {xapi_cgroup}/external/intrapool;
- {xapi_cgroup}/external/unauthenticated;
- {xapi_cgroup}/external/authenticated/{identity};
where {identity} is a {auth_user_sid}/{user_agent}.
Both {auth_user_sid} and {user_agent} strings are sanitized when
making the identity through `Identity.make`, by allowing only
alphanumenric characters and a maximum length of 16 characters each.
This is only the library change.
This should allow for proper thread classification in xapi.
Signed-off-by: Gabriel Buica <[email protected]>
psafont
reviewed
Dec 4, 2024
GabrielBuica
force-pushed
the
private/dbuica/feature/perf/tgroups-part-2
branch
from
fc0da95 to
90b296c
Compare
Adds unit test for: - the correct thread classification of `of_creator`; - sanitation of `Identity.make`. Signed-off-by: Gabriel Buica <[email protected]>
Classifies the threads at the time of session creation and inside `do_dispatch`. This ensures that new threads created by current session/request inherit the propper classification. Note: threads created by xenopsd calling back into xapi are yet to be classified. Signed-off-by: Gabriel Buica <[email protected]>
GabrielBuica
force-pushed
the
private/dbuica/feature/perf/tgroups-part-2
branch
from
f91bdb1 to
62a903a
Compare
lindig
reviewed
Dec 10, 2024
| |> Option.map sanitize | ||
| |> Option.map (fun user_agent -> | ||
| let len = Int.min (String.length user_agent) 16 in | ||
| String.sub user_agent 0 len |
There was a problem hiding this comment.
Do we have to care about collisions? If we consider only the sanitized prefix, we could end up with collisions of the shortened names.
There was a problem hiding this comment.
I don't think collisions matter that much in this case. If the we end up with the same shortened names they should be under the same classification. The important aspect was to differentiate between auth_user_sids.
lindig
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more granurality in the xapi thread classification. Now, an
individual thread can be mapped to the following:
where {identity} is a {auth_user_sid}/{user_agent}.
Both {auth_user_sid} and {user_agent} strings are sanitized when
making the identity through
Identity.make, by allowing onlyalphanumeric characters and a maximum length of 16 characters each.
This should allow for proper thread classification in xapi.
Note: Threads calling back into xapi from xenopsd are yet to be classified.
e.g. Cgroup hierarchy based on the new classification
BVT: 208947 & BST: 208972