-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fingerprint_sha256 and fingerprint_sha1 empty after upgrade for user certs in /etc/stunnel/certs/ #5955
Comments
Thanks for reporting the issue, I've created CA-398341 to track this internally. I've created a branch with an untested patch: master...psafont:xen-api:private/paus/fingers-crossed I'm going on holidays tomorrow, so somebody else will need to pick up the work. |
So, we released an update with this fix, and a tester found their XAPI not starting anymore. One year ago, they had removed a certificate manually from disk without uninstalling it cleanly from XAPI. XAPI attempts to update its metadata, but fails on the missing file. We downgraded XAPI, ran We probably shouldn't make XAPI startup fail in this situation. |
Log extract:
|
Grepping on
|
Hi, thank you for reporting this and the suggestion for using --force! I have incorporated both a fix for this issue and new --force functionality into this PR: #6006 |
I'm on XAPI 24.19.2, to which I applied this fix so that the new fingerprint fields are filled.
However, this wasn't enough, and after a XAPI restart I still have a certificate for which these fields are empty:
I'm not very good at reading ocaml changesets, but it looks like #5786 left aside user certificates and only fixed host certificates.
It turns out this has real consequences, as our automated tests detected. Consider the following scenario.
fingerprint_sha256
field remains empty.fingerprint_sha256
, which is empty on pool A and not empty in host B1. The check fails, and the pool join fails with : "The host joining the pool has different CA certificates from the pool coordinator while using the same name, uninstall them and try again".The relevant code for this check is here: https://github.com/xapi-project/xen-api/blob/master/ocaml/xapi/xapi_pool.ml#L764
CCing @snwoods as the committer of PR #5786.
The text was updated successfully, but these errors were encountered: