Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msbuild] Remove the GetBundleResourceWithLogicalNameItems target, it's not used anymore. #21690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[msbuild] Remove the GetBundleResourceWithLogicalNameItems target, it's not used anymore. #21690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.Common.After.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,31 +28,6 @@ Copyright (C) 2011-2013 Xamarin. All rights reserved.
DependsOnTargets="_SayHello"
BeforeTargets="_CleanDebugSymbols;_CleanAppBundle;_DetectAppManifest;_DetectSdkLocations;_GenerateBundleName" />

<PropertyGroup>
<CreateAppBundleDependsOn>
GetBundleResourceWithLogicalNameItems;
$(CreateAppBundleDependsOn)
</CreateAppBundleDependsOn>
</PropertyGroup>

<Target Name="GetBundleResourceWithLogicalNameItems" Returns="@(_BundleResourceWithLogicalName)" DependsOnTargets="_GenerateBundleName">
<ItemGroup>
<!-- We need this metadata to fix the source in VS -->
<_BundleResourceWithLogicalName>
<BuildSessionId>$(BuildSessionId)</BuildSessionId>
<BuildServerPath>..\..\$(BuildAppName)\$(BuildSessionId)\%(Identity)</BuildServerPath>
<BuildServerPath Condition="'$(IsWatchApp)' == 'true' Or '$(IsAppExtension)' == 'true'">..\..\$(_AppBundleName)\$(BuildSessionId)\%(Identity)</BuildServerPath>
</_BundleResourceWithLogicalName>
</ItemGroup>
<CollectMonotouchReferences References="@(_MSBuildProjectReferenceExistent)">
<Output TaskParameter="MonoTouchReferences" ItemName="MonoTouchReferences" />
</CollectMonotouchReferences>
<!-- This will collect the bundle resource items in the referenced projects -->
<MSBuild Projects="@(MonoTouchReferences)" Targets="GetBundleResourceWithLogicalNameItems" BuildInParallel="$(BuildInParallel)" RebaseOutputs="true" Properties="%(MonoTouchReferences.SetConfiguration); %(MonoTouchReferences.SetPlatform)" Condition="'@(MonoTouchReferences)' != '' and '%(MonoTouchReferences.Private)' != 'false' and '$(UseCommonOutputDirectory)' != 'true'" ContinueOnError="$(ContinueOnError)">
<Output TaskParameter="TargetOutputs" ItemName="_BundleResourceWithLogicalName" />
</MSBuild>
</Target>

<PropertyGroup>
<CreateIpaDependsOn>
$(CreateIpaDependsOn);
Expand Down