Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timing in docs/index.html #2

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Fix timing in docs/index.html #2

merged 3 commits into from
Jun 16, 2022

Conversation

wulfland
Copy link
Owner

This commit fixes the timing error in docs/index.html by setting
correct start and min properties for the speed object.

This commit fixes #1

@wulfland wulfland added the bug Something isn't working label Jun 16, 2022
@wulfland wulfland self-assigned this Jun 16, 2022
This commit fixes the timing error in docs/index.html by setting
correct start and min properties for the speed object.

This commit fixes #1
@wulfland wulfland force-pushed the users/wulfland/1_fix-game branch from 11dec34 to b873009 Compare June 16, 2022 08:21
@wulfland wulfland marked this pull request as ready for review June 16, 2022 10:54
@wulfland wulfland requested a review from kaufm as a code owner June 16, 2022 10:54
docs/index.html Outdated Show resolved Hide resolved
@wulfland wulfland enabled auto-merge (squash) June 16, 2022 11:09
@wulfland wulfland merged commit 57023b8 into main Jun 16, 2022
Copy link
Collaborator

@kaufm kaufm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - looks good 🏅

@@ -75,7 +75,7 @@
ctx = canvas.getContext('2d'),
ucanvas = get('upcoming'),
uctx = ucanvas.getContext('2d'),
speed = { start: 1000.6, decrement: 0.005, min: 1.1 }, // how long before piece drops by 1 row (seconds)
speed = { start: 0.6, decrement: 0.006, min: 0.1 }, // how long before piece drops by 1 row (seconds)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it look good 👍

@wulfland wulfland deleted the users/wulfland/1_fix-game branch June 16, 2022 11:13
wulfland added a commit that referenced this pull request Jun 16, 2022
wulfland added a commit that referenced this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Fix game
2 participants