-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralized test runner for backend-features
specifications
#429
Open
pklaschka
wants to merge
21
commits into
main
Choose a base branch
from
feat/custom-test-runner
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,157
−718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't really do a whole lot and just adds clutter at the moment.
pklaschka
added
📕 documentation
Improvements or additions to documentation
🌷 enhancement
New feature or request
dependencies
Pull requests that update a dependency file
🏃 github_actions
GitHub Action changes that hit almost all workflows in the ecosystem
labels
Dec 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 23 out of 38 changed files in this pull request and generated no comments.
Files not reviewed (15)
- .github/workflows/backend-features-lint.yml: Language not supported
- backend-deno/Dockerfile: Language not supported
- backend-deno/docker-compose.yml: Language not supported
- backend-features/.gherkin-lintrc: Language not supported
- backend-features/.gitignore: Language not supported
- backend-features/Dockerfile: Language not supported
- backend-features/auth.feature: Language not supported
- backend-features/config.feature: Language not supported
- backend-features/dev-mode.feature: Language not supported
- backend-features/docker-compose.yml: Language not supported
- backend-deno/cucumber/README.md: Evaluated as low risk
- backend-deno/cucumber/step-registry.ts: Evaluated as low risk
- backend-deno/cucumber/steps/config.ts: Evaluated as low risk
- backend-deno/cucumber/steps/nats.ts: Evaluated as low risk
- backend-deno/cucumber/steps/start.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)
backend-deno/testbed.e2e.ts:44
- [nitpick] The variable
nats
is used without a clear declaration or type. Consider declaring it explicitly for better readability.
const nats = res.nc;
backend-deno/testbed.e2e.ts:65
- The error message 'Unknown error' is vague. Consider providing more context or details about the error.
result.error = "Unknown error";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📕 documentation
Improvements or additions to documentation
dependencies
Pull requests that update a dependency file
🏃 github_actions
GitHub Action changes that hit almost all workflows in the ecosystem
🌷 enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable easy (end-to-end-like) testing of Telestion Service libraries against the specifications specified in
backend-features
using a Python test runner (using the Gherkin specification files) that runs Docker containers.Details
The test runner can be called in any directory, and you must pass the relative path from the CWD to a folder containing a
Dockerfile
that has the service as itsENTRYPOINT
(cf. the specifications inbackend-features/TESTBED.spec.md
.Additional information
The output of a test run with the verbose flag enabled looks like this:
run-tests.py -v .
main
backend-features
specifications #429 👈backend-go
#430