Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(frontend-react): ⬆️ Upgrade frontend dependencies #424

Merged
merged 17 commits into from
Dec 12, 2024

Conversation

pklaschka
Copy link
Member

@pklaschka pklaschka commented Dec 2, 2024

Upgrades all direct frontend dependencies to their latest versions.

Functionality was manually verified using tests and the application.

Upgrades all direct frontend dependencies to their latest versions.

Functionality was manually verified using tests and the application.
@pklaschka pklaschka requested a review from fussel178 as a code owner December 2, 2024 14:53
@pklaschka pklaschka enabled auto-merge (squash) December 2, 2024 15:01
@pklaschka pklaschka disabled auto-merge December 2, 2024 15:01
@pklaschka pklaschka enabled auto-merge December 2, 2024 15:02
@pklaschka pklaschka self-assigned this Dec 2, 2024
@pklaschka pklaschka added the dependencies Pull requests that update a dependency file label Dec 2, 2024
@pklaschka pklaschka requested a review from Copilot December 6, 2024 15:31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • frontend-react/package.json: Language not supported
@pklaschka pklaschka marked this pull request as draft December 6, 2024 18:56
auto-merge was automatically disabled December 6, 2024 18:56

Pull request was converted to draft

@pklaschka pklaschka requested a review from Copilot December 6, 2024 19:22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 17 changed files in this pull request and generated no suggestions.

Files not reviewed (10)
  • frontend-react/package.json: Language not supported
  • frontend-react/src/lib/widget/configuration/configuration-context.tsx: Evaluated as low risk
  • frontend-react/src/lib/application/routes/migration/migration-page.tsx: Evaluated as low risk
  • frontend-react/src/lib/application/routes/dashboard-editor/layout-editor/components/empty-cell.tsx: Evaluated as low risk
  • frontend-react/src/lib/user-data/state.ts: Evaluated as low risk
  • frontend-react/src/lib/application/routes/migration/components/existing-user-prompt.tsx: Evaluated as low risk
  • frontend-react/src/app/index.tsx: Evaluated as low risk
  • frontend-react/src/lib/application/routes/migration/components/new-user-prompt.tsx: Evaluated as low risk
  • frontend-react/src/lib/application/routes/dashboard-page/routing.ts: Evaluated as low risk
  • frontend-react/src/lib/application/routes/dashboard-editor/layout-editor/components/layout-editor.tsx: Evaluated as low risk
Comments skipped due to low confidence (1)

frontend-react/src/lib/auth/controller.ts:43

  • Removing the error parameter in the catch block can hide useful debugging information. Consider keeping the error parameter to log or handle the error appropriately.
} catch {
@pklaschka
Copy link
Member Author

PR is mostly ready for review. We still need to migrate to the new ESLint config stuff – cf. https://eslint.org/docs/latest/use/configure/migration-guide – to accomodate the ESLint upgrade, though.

@pklaschka pklaschka marked this pull request as ready for review December 6, 2024 21:41
@pklaschka pklaschka enabled auto-merge December 7, 2024 01:52
@pklaschka pklaschka added the 💥 breaking A braking change / PR containing breaking changes label Dec 9, 2024
…ite upgrade

With the Vite upgrade to v6, the CSS file got renamed:
<https://vite.dev/guide/migration#customize-css-output-file-name-in-library-mode>.

This means we have to adjust the name in the `exports` of the
`package.json`, as well. This is actually quite nice because the name
now matches the one actually imported. But still: requires a change.
That's what this commit does. Nothing more, nothing less.
@pklaschka
Copy link
Member Author

Ok... I have no idea how that just broke the CI. Must look into that later.

Copy link
Member

@fussel178 fussel178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎲

@pklaschka pklaschka merged commit fe6ebb1 into main Dec 12, 2024
17 checks passed
@pklaschka pklaschka deleted the deps/frontend-react branch December 12, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 breaking A braking change / PR containing breaking changes dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants