Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC Authentication support #5

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Add OIDC Authentication support #5

merged 4 commits into from
Dec 10, 2024

Conversation

pklaschka
Copy link
Member

Implement OpenID Connect (OIDC) authentication, enabling user authentication when the OIDC_ISSUER environment variable is set. Remove unnecessary imports and update relevant routes to utilize the new authentication middleware. Document OIDC configuration options.

OIDC Authentication will be enabled when the
`OIDC_ISSUER` environment variable is set.
@pklaschka pklaschka requested a review from Copilot December 1, 2024 11:59
@pklaschka pklaschka self-assigned this Dec 1, 2024
@pklaschka pklaschka requested a review from fussel178 December 1, 2024 11:59
@pklaschka pklaschka added 📌 security Pull requests that address a security vulnerability 🌷 enhancement New feature or request labels Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 9 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • deno.json: Language not supported
  • example.env: Language not supported
  • lib/http/middleware/oidc.ts: Evaluated as low risk
Comments skipped due to low confidence (1)

lib/http/asn-metadata-from-context.ts:15

  • Ensure that c.var.user is defined before adding it to the metadata object to prevent potential issues with undefined or null values.
user: c.var.user,
@pklaschka pklaschka requested a review from Copilot December 1, 2024 12:01

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 10 changed files in this pull request and generated no suggestions.

Files not reviewed (4)
  • deno.json: Language not supported
  • example.env: Language not supported
  • lib/http/middleware/oidc.ts: Evaluated as low risk
  • lib/http/routes/api.ts: Evaluated as low risk
Comments skipped due to low confidence (1)

lib/http/asn-metadata-from-context.ts:15

  • The variable 'user' might be undefined if the middleware does not set it. Ensure that 'user' is always set or handle the case where it might be undefined.
user: c.var.user,
Copy link
Member

@fussel178 fussel178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕹️

@fussel178 fussel178 merged commit fc6c287 into main Dec 10, 2024
1 check passed
@fussel178 fussel178 deleted the feat/oidc branch December 10, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 security Pull requests that address a security vulnerability 🌷 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants