Skip to content

Commit

Permalink
Revert trimming test workarounds (dotnet#58272)
Browse files Browse the repository at this point in the history
  • Loading branch information
MackinnonBuck authored Oct 17, 2024
1 parent 1890959 commit 109c0d4
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 14 deletions.
5 changes: 0 additions & 5 deletions eng/testing/linker/ILLink.Descriptors.xml

This file was deleted.

7 changes: 0 additions & 7 deletions eng/testing/linker/project.csproj.template
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,4 @@
{AdditionalProjectReferences}
</ItemGroup>

<!-- Workaround for trimming tests failing during execution. -->
<ItemGroup>
<EmbeddedResource Include="ILLink.Descriptors.xml">
<LogicalName>ILLink.Descriptors.xml</LogicalName>
</EmbeddedResource>
</ItemGroup>

</Project>
2 changes: 0 additions & 2 deletions eng/testing/linker/trimmingTests.targets
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@
<Copy SourceFiles="$(_projectSourceFile);
@(_additionalProjectSourceFiles)"
DestinationFolder="$(_projectDir)" />
<Copy SourceFiles="$(MSBuildThisFileDirectory)ILLink.Descriptors.xml"
DestinationFolder="$(_projectDir)" />
<Message Text="Generated $(_projectFile)" />
</Target>

Expand Down
1 change: 1 addition & 0 deletions src/SignalR/server/Core/src/DynamicHub.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics.CodeAnalysis;

namespace Microsoft.AspNetCore.SignalR;

/// <summary>
Expand Down

0 comments on commit 109c0d4

Please sign in to comment.