Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): add AppShell component #29

Merged
merged 5 commits into from
Feb 16, 2023
Merged

feat(react): add AppShell component #29

merged 5 commits into from
Feb 16, 2023

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Feb 15, 2023 •
edited
Loading

Purpose

Add AppShell component to Oxygen UI component library.

Dark

Screenshot 2023-02-16 at 12 19 02

Screenshot 2023-02-16 at 12 19 11

Light

Screenshot 2023-02-16 at 12 20 05

Screenshot 2023-02-16 at 12 20 16

Related Issues

Related PRs

  • N/A

Checklist

  • UX/UI review done on the final implementation.
  • Story provided. (Add screenshots)
  • Manual test round performed and verified.
  • Unit tests provided. (Add links if there are any)
  • Documentation provided. (Add links if there are any)

Security checks

@brionmario brionmario mentioned this pull request Feb 15, 2023
Open
73 tasks
thivi
thivi previously approved these changes Feb 16, 2023
View reviewed changes
packages/react/src/components/AppShell/app-shell.scss Outdated Show resolved Hide resolved
@brionmario brionmario merged commit a84290d into wso2:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savindi7 savindi7 savindi7 approved these changes

@thivi thivi thivi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brionmario @thivi @savindi7