Change javax.xml.soap import-package version #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruwanta
reviewed
Feb 4, 2020
| !org.springframework.*; version=${exp.pkg.version.spring}, | ||
| javax.xml.stream.*; version="1.0.1", | ||
| javax.xml.soap; version="0.0.0", | ||
| *;resolution:=optional |
There was a problem hiding this comment.
Better if we put the respective imports by name and version ranges.
ruwanta
reviewed
Feb 4, 2020
| javax.xml.soap; version="0.0.0", | ||
| *;resolution:=optional | ||
| </Import-Package> | ||
| <DynamicImport-Package>*</DynamicImport-Package> |
There was a problem hiding this comment.
Do we really want dynamic import.
i.e. do we use "class.forName()" within "spring.framework"?
There was a problem hiding this comment.
I think we don't use class.forName() within "spring.framework"? Since this is an orbit and dynamic import was there for a long we will skip this at the moment. We will address this with wso2/carbon-kernel#2582
madurangasiriwardena
approved these changes
Feb 6, 2020
IsuraD
approved these changes
Feb 6, 2020
madurangasiriwardena
approved these changes
Feb 6, 2020
shilmyhasan
pushed a commit
to shilmyhasan/orbit-1
that referenced
this pull request
Feb 8, 2024
Bump esapi version to latest in opensaml-3.3.1.wso2v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the issue - wso2/product-is#6770