-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error page for UAE Pass authenticator #7288
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7288 +/- ##
==========================================
+ Coverage 32.32% 36.04% +3.71%
==========================================
Files 42 42
Lines 897 899 +2
Branches 204 222 +18
==========================================
+ Hits 290 324 +34
+ Misses 607 575 -32
Flags with carried forward coverage won't be shown. Click here to find out more. |
identity-apps-core/apps/authentication-portal/src/main/webapp/uaePassError.jsp
Show resolved
Hide resolved
...urces/org/wso2/carbon/identity/application/authentication/endpoint/i18n/Resources.properties
Show resolved
Hide resolved
identity-apps-core/apps/authentication-portal/src/main/webapp/uaePassError.jsp
Show resolved
Hide resolved
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
LGTM. +1 to merge from my side. |
Purpose
This pull request includes updates to the internationalization files for the authentication portal and the addition of a new JSP file to handle UAE Pass authentication errors. The changes primarily focus on adding support for UAE Pass error messages in multiple languages and introducing a new error page.
Internationalization updates:
Resources.properties
file for English.Resources_de_DE.properties
file for German.Resources_es_ES.properties
file for Spanish.Resources_fr_FR.properties
file for French.Resources_ja_JP.properties
file for Japanese.Resources_pt_BR.properties
file for Brazilian Portuguese.Resources_pt_PT.properties
file for European Portuguese.Resources_zh_CN.properties
file for Simplified Chinese.New error page:
uaePassError.jsp
to display UAE Pass specific error messages to the user, including handling user-cancelled authentication and other failure scenarios.Related Issues
Related PRs
Checklist
Security checks