Make console settings UI configurable for managed deployments #6938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6938 +/- ##
=======================================
Coverage 31.79% 31.79%
=======================================
Files 41 41
Lines 890 890
Branches 220 220
=======================================
Hits 283 283
+ Misses 587 557 -30
- Partials 20 50 +30
Flags with carried forward coverage won't be shown. Click here to find out more. |
brionmario
reviewed
Sep 27, 2024
...le-settings.v1/components/console-administrators/administrators-list/administrators-list.tsx
Outdated
Show resolved
Hide resolved
pavinduLakshan
force-pushed
the
enable_console_settings_cloud
branch
from
dd46878 to
a354b33
Compare
pavinduLakshan
force-pushed
the
enable_console_settings_cloud
branch
from
7564634 to
dfde4f2
Compare
DonOmalVindula
previously approved these changes
Oct 1, 2024
...admin.console-settings.v1/components/console-roles/console-roles-edit/console-roles-edit.tsx
Outdated
Show resolved
Hide resolved
features/admin.console-settings.v1/components/console-roles/console-roles-list-layout.tsx
Outdated
Show resolved
Hide resolved
...le-settings.v1/components/console-administrators/administrators-list/administrators-list.tsx
Outdated
Show resolved
Hide resolved
...le-settings.v1/components/console-administrators/administrators-list/administrators-list.tsx
Outdated
Show resolved
Hide resolved
...le-settings.v1/components/console-administrators/administrators-list/administrators-list.tsx
Outdated
Show resolved
Hide resolved
brionmario
reviewed
Oct 1, 2024
brionmario
reviewed
Oct 1, 2024
features/admin.console-settings.v1/components/console-roles/console-roles-list-layout.tsx
Outdated
Show resolved
Hide resolved
brionmario
reviewed
Oct 1, 2024
features/admin.console-settings.v1/components/console-settings-tabs.tsx
Outdated
Show resolved
Hide resolved
DonOmalVindula
approved these changes
Oct 1, 2024
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
|
Will fix the eslint warning in a followup PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Related Issues
Related PRs
Checklist
Security checks