Address PR comments.

wso2 · Oct 6, 2024 · 5be8d4b · 5be8d4b
1 parent d796268
commit 5be8d4b
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 11 deletions.
diff --git a/features/admin.applications.v1/constants/application-management.ts b/features/admin.applications.v1/constants/application-management.ts
@@ -42,7 +42,7 @@ export class ApplicationManagementConstants {
     public static readonly DEFAULT_APPS: string[] = [ this.MY_ACCOUNT_APP_NAME ];
 
     /**
-     * Application latest version.
+     * When a new Application version is released, this variable should to be updated.
      */
     public static readonly LATEST_VERSION: string = "v1.0.0";
 

diff --git a/features/admin.applications.v1/pages/application-edit.tsx b/features/admin.applications.v1/pages/application-edit.tsx
@@ -160,7 +160,7 @@ const ApplicationEditPage: FunctionComponent<ApplicationEditPageInterface> = (
 
     useEffect(() => {
         if (application != undefined && applicationInboundConfigs != undefined) {
-            const isAppOutdated: boolean = ApplicationManagementUtils.getIfAppIsOutdated(
+            const isAppOutdated: boolean = ApplicationManagementUtils.isApplicationOutdated(
                 application?.applicationVersion, applicationInboundConfigs?.grantTypes);
 
             setDisplayBanner(isAppOutdated);

diff --git a/features/admin.applications.v1/utils/application-management-utils.ts b/features/admin.applications.v1/utils/application-management-utils.ts
@@ -104,7 +104,7 @@ export class ApplicationManagementUtils {
             });
     }
 
-    public static getIfAppIsOutdated(applicationVersion: string, grantTypes?: string[]): boolean {
+    public static isApplicationOutdated(applicationVersion: string, grantTypes?: string[]): boolean {
 
         if (applicationVersion != undefined
                 && grantTypes.includes(ApplicationManagementConstants.CLIENT_CREDENTIALS_GRANT)) {

diff --git a/features/admin.core.v1/models/common.ts b/features/admin.core.v1/models/common.ts
@@ -1,5 +1,5 @@
 /**
- * Copyright (c) 2024, WSO2 LLC. (https://www.wso2.com).
+ * Copyright (c) 2023-2024, WSO2 LLC. (https://www.wso2.com).
  *
  * WSO2 LLC. licenses this file to you under the Apache License,
  * Version 2.0 (the "License"); you may not use this file except

diff --git a/modules/i18n/src/translations/en-US/portals/applications.ts b/modules/i18n/src/translations/en-US/portals/applications.ts
@@ -1656,19 +1656,19 @@ export const applications: ApplicationsNS = {
                     documentationHint: "More Details",
                     confirmationModal: {
                         header: "Have you done the relevant changes?",
-                        message: "Proceeding the action without making relevant change will cause the client application behavior break.",
-                        content: "This action is irreversible and will permanently update the application.",
+                        message: "Proceeding without making the necessary changes will cause the client application's behavior to break.",
+                        content: "This action is irreversible and will result in a permanent update to the application.",
                         assertionHint: "Please confirm your action"
                     },
                     fields: {
                         commonInstruction: "Following behavioral changes will be applied upon update.",
                         versions: {
                             version100: {
                                 removeUsernameFromIntrospectionRespForAppTokens: {
-                                    instruction: "Introspection response for application access token will not include the username attribute."
+                                    instruction: "The introspection response for an application access token will not include the username attribute."
                                 },
                                 useClientIdAsSubClaimOfAppTokens: {
-                                    instruction: "Application access token sub attribute will be client_id generated for an application."
+                                    instruction: "The sub attribute of the application access token will be the client_id generated for the application."
                                 }
                             }
                         }

diff --git a/modules/react-components/src/components/page-header/page-header.tsx b/modules/react-components/src/components/page-header/page-header.tsx
@@ -306,9 +306,7 @@ export const PageHeader: React.FunctionComponent<PageHeaderPropsInterface> = (
                                 )
                         )
                     }
-                    {
-                        alertBanner
-                    }
+                    { alertBanner }
                     {
                         action
                             ? (
-Original file line number
+Diff line change
@@ Expand Up @@
                                     )
                             )
                         }
-                        {
-                            alertBanner
-                        }
+                        { alertBanner }
                         {
                             action
                                 ? (
@@ Expand Down @@