Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accelerator 4] Modifying AM and IAM accelerator modules #126

Merged
merged 5 commits into from
Sep 30, 2024
Merged

[Accelerator 4] Modifying AM and IAM accelerator modules #126

merged 5 commits into from
Sep 30, 2024

Conversation

Ashi1993
Copy link
Contributor

Modifying AM and IAM accelerator modules

Explain in a few lines the purpose of this pull request

Issue link: required

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: Spec, product, version, type (specify requested labels)

Development Checklist

  1. Build complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verified the PR doesn't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Verified tests in multiple database environments (if applicable).
  3. Tested with BI enabled (if applicable).

anjuchamantha
anjuchamantha reviewed Sep 30, 2024
View reviewed changes
...accelerator/accelerators/fs-is/carbon-home/repository/components/dropins/classmate-1.5.1.jar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding jars to the repo, can't we have them at compile time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are adding these jars to the base products, thats why we kept this

@anjuchamantha anjuchamantha merged commit ccaa8bc into wso2:main Sep 30, 2024
2 checks passed
@Ashi1993 Ashi1993 changed the title Modifying AM and IAM accelerator modules [Accelerator 4] Modifying AM and IAM accelerator modules Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjuchamantha anjuchamantha anjuchamantha approved these changes

@Akila94 Akila94 Akila94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashi1993 @Akila94 @anjuchamantha