Fixing review comments

wso2 · Oct 22, 2024 · eab9599 · eab9599
1 parent a4f614e
commit eab9599
Show file tree

Hide file tree

Showing 2 changed files with 60 additions and 3 deletions.
diff --git a/...cial/services/accelerator/consent/mgt/extensions/authorize/util/ConsentAuthorizeUtil.java b/...cial/services/accelerator/consent/mgt/extensions/authorize/util/ConsentAuthorizeUtil.java
@@ -448,14 +448,13 @@ public static JSONArray appendDummyAccountID() {
 
         JSONArray accountsJSON = new JSONArray();
         JSONObject accountOne = new JSONObject();
-        accountOne.put("account_id", "12345");
+        accountOne.put("account_id", "30080012343456");
         accountOne.put("display_name", "Salary Saver Account");
 
         accountsJSON.put(accountOne);
 
         JSONObject accountTwo = new JSONObject();
-        accountTwo.put("account_id", "67890");
-        accountTwo.put("account_id", "67890");
+        accountTwo.put("account_id", "30080098763459");
         accountTwo.put("display_name", "Max Bonus Account");
 
         accountsJSON.put(accountTwo);

diff --git a/...in/java/org/wso2/financial/services/accelerator/demo/backend/services/AccountService.java b/...in/java/org/wso2/financial/services/accelerator/demo/backend/services/AccountService.java
@@ -36,6 +36,64 @@
 @Path("/accountservice/")
 public class AccountService {
 
+    @SuppressFBWarnings("JAXRS_ENDPOINT")
+    // Suppressed content - Endpoint
+    // Suppression reason - False Positive : This endpoint is a demo endpoint that is not exposed in production
+    // Suppressed warning count - 1
+    @GET
+    @Path("/accounts")
+    @Produces("application/json; charset=utf-8")
+    public Response getAccounts(@HeaderParam("x-fapi-interaction-id") String xFapiInteractionId,
+                                @HeaderParam("Account-Request-Information") String accountRequestInfo) {
+
+        String finalRespose = "{\n" +
+                "  \"Data\": {\n" +
+                "    \"Account\": [\n" +
+                "      {\n" +
+                "        \"AccountId\": \"30080012343456\",\n" +
+                "        \"Status\": \"Enabled\",\n" +
+                "        \"StatusUpdateDateTime\": \"2020-04-16T06:06:06+00:00\",\n" +
+                "        \"Currency\": \"GBP\",\n" +
+                "        \"AccountType\": \"Personal\",\n" +
+                "        \"AccountSubType\": \"CurrentAccount\",\n" +
+                "        \"Nickname\": \"Bills\",\n" +
+                "        \"OpeningDate\": \"2020-01-16T06:06:06+00:00\",\n" +
+                "        \"MaturityDate\": \"2025-04-16T06:06:06+00:00\",\n" +
+                "        \"Account\": [{\n" +
+                "          \"SchemeName\": \"SortCodeAccountNumber\",\n" +
+                "          \"Identification\": \"30080012343456\",\n" +
+                "          \"Name\": \"Mr Kevin\",\n" +
+                "          \"SecondaryIdentification\": \"00021\"\n" +
+                "        }]\n" +
+                "      },\n" +
+                "      {\n" +
+                "        \"AccountId\": \"30080098763459\",\n" +
+                "        \"Status\": \"Enabled\",\n" +
+                "        \"StatusUpdateDateTime\": \"2020-04-16T06:06:06+00:00\",\n" +
+                "        \"Currency\": \"GBP\",\n" +
+                "        \"AccountType\": \"Personal\",\n" +
+                "        \"AccountSubType\": \"CurrentAccount\",\n" +
+                "        \"Nickname\": \"Bills\",\n" +
+                "        \"OpeningDate\": \"2020-01-16T06:06:06+00:00\",\n" +
+                "        \"MaturityDate\": \"2025-04-16T06:06:06+00:00\"\n" +
+                "      }\n" +
+                "    ]\n" +
+                "  },\n" +
+                "  \"Links\": {\n" +
+                "    \"Self\": \"https://api.alphabank.com/open-banking/v4.0/accounts\"\n" +
+                "  },\n" +
+                "  \"Meta\": {\n" +
+                "    \"TotalPages\": 1\n" +
+                "  }\n" +
+                "}";
+
+        if (xFapiInteractionId == null) {
+            xFapiInteractionId = UUID.randomUUID().toString();
+        }
+        return Response.status(200).entity(finalRespose)
+                .header("x-fapi-interaction-id", xFapiInteractionId).build();
+    }
+
     @SuppressFBWarnings("JAXRS_ENDPOINT")
     // Suppressed content - Endpoint
     // Suppression reason - False Positive : This endpoint is a demo endpoint that is not exposed in production