Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register the application templates API under the application view scope #6244

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

DilshanSenarath
Copy link
Contributor

@DilshanSenarath DilshanSenarath commented Dec 31, 2024

Purpose

Usable application templates were introduced to the extension management API as part of the SSO templates onboarding feature. However, the applications feature requires the internal_extensions_view scope to retrieve application templates from the extension management API. Adding this scope to the applications feature would necessitate a console role migration, as it cannot be implemented in a backward-compatible manner for the UI.

To address this, this PR registers the application templates endpoint as a separate API with the internal_application_mgt_view scope, allowing application templates to be extracted without requiring additional scopes. Other templates in the extension management API will still be accessed using the internal_extensions_view scope to maintain backward compatibility.

Additionally, this PR removes the previously added internal_extensions_view scope for applications feature, as it is no longer needed. Application templates can now be accessed using the internal_application_mgt_view scope.

Related Issue

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (f70492e) to head (46173bf).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master    #6244    +/-   ##
==========================================
  Coverage     45.69%   45.70%            
+ Complexity    14078    14059    -19     
==========================================
  Files          1633     1633            
  Lines        100914   100656   -258     
  Branches      17730    17696    -34     
==========================================
- Hits          46117    46004   -113     
+ Misses        48080    47956   -124     
+ Partials       6717     6696    -21     
Flag Coverage Δ
unit 28.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12573110254

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12573110254
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12575841749

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12575841749
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12575841749

@DilshanSenarath DilshanSenarath merged commit b87a7f9 into wso2:master Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants