-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce New Templates for Custom Authenticators #6226
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6226 +/- ##
============================================
- Coverage 45.66% 45.65% -0.02%
- Complexity 14040 14209 +169
============================================
Files 1632 1638 +6
Lines 100532 102651 +2119
Branches 17421 16959 -462
============================================
+ Hits 45911 46865 +954
- Misses 47931 48962 +1031
- Partials 6690 6824 +134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...ntity.extension.mgt.feature/resources/extensions/connections/custom-authentication/info.json
Outdated
Show resolved
Hide resolved
...nsion.mgt.feature/resources/extensions/connections/twofactor-custom-authentication/info.json
Outdated
Show resolved
Hide resolved
"name": "Custom Authentication", | ||
"description": "Enable login for users with external authentication service.", | ||
"image": "", | ||
"category": "DEFAULT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is meant by this param. What are the other available categories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, all the available connections fall under the DEFAULT category. If we are introducing a new category with custom authentication, we would have to initiate that separately.
"description": "Enable login for users with external authentication service.", | ||
"image": "", | ||
"category": "DEFAULT", | ||
"displayOrder": -1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is meant by -1. What is purpose of this parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to represent the order in which the card will be displayed on the connections page. -1 implies that the specific card would be skipped from the order by and will be displayed at the end of the list.
...n.mgt.feature/resources/extensions/connections/twofactor-custom-authentication/template.json
Outdated
Show resolved
Hide resolved
0b87e26
to
2187fe9
Compare
bfecc94
to
8e22f37
Compare
Quality Gate passedIssues Measures |
Proposed changes in this pull request
This PR introduces new JSON files related to custom authenticators. Three types of custom authenticators are introduced which will be grouped under a generic custom-authentication template.
Following are the template-ids of the newly added templates.
The following is the proposed UI design that'd display the rendered content. This will be added to the product as a new connection.
Related Emails:
[Architecture] Facilitate user authentication via a external service (custom authentication extension)
Related Issue
When should this PR be merged
[Please describe any preconditions that need to be addressed before we
can merge this pull request.]
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation