Added custom API Indexing handler to bypass indexing of old API revisions. #12725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oshanath
requested review from
tharindu1st,
AnuGayan,
chamilaadhi,
Arshardh,
dushaniw and
tgtshanika
as code owners
tharindu1st
approved these changes
Dec 16, 2024
npamudika
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Editing old API revisions result in a Null Pointer Exception due to null being returned from here and that null being accessed here
This fix will create a new Indexing Handler that extends the Indexer handler in the carbon registry. it will check if the API being processed is an old revision, and will return immediately if so.
If it's a current API, it will call the superclass method which will trigger indexing as usual.
The registry.xml.j2 file of the product will have to be updated so that the Indexing handler is pointed to the new class.
This will fix the public issue - wso2/api-manager#3392