Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch Feature/conformance #2455

Closed
wants to merge 40 commits into from
Closed

Conversation

AmaliMatharaarachchi
Copy link
Contributor

@AmaliMatharaarachchi AmaliMatharaarachchi commented Sep 12, 2024

Purpose

Fixes #2403
Design doc - https://docs.google.com/document/d/1fwDWKK_yZ3TXfdcA3vSX4Kg_plcg-JBYoobAiwyudtY/edit#heading=h.35yjoemxqx92

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@AmaliMatharaarachchi AmaliMatharaarachchi marked this pull request as draft September 12, 2024 08:04
@AmaliMatharaarachchi AmaliMatharaarachchi force-pushed the feature/conformance branch 2 times, most recently from a90635e to d76e2f8 Compare September 23, 2024 08:58
@AmaliMatharaarachchi AmaliMatharaarachchi added the trigger-action When this includes apk actions getting trigger for pr label Sep 23, 2024
@AmaliMatharaarachchi AmaliMatharaarachchi marked this pull request as ready for review September 23, 2024 09:03
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Sep 23, 2024
@AmaliMatharaarachchi AmaliMatharaarachchi added the trigger-action When this includes apk actions getting trigger for pr label Sep 23, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Sep 23, 2024
@AmaliMatharaarachchi AmaliMatharaarachchi added the trigger-action When this includes apk actions getting trigger for pr label Sep 23, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Sep 24, 2024
@AmaliMatharaarachchi AmaliMatharaarachchi added the trigger-action When this includes apk actions getting trigger for pr label Sep 24, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Sep 24, 2024
@AmaliMatharaarachchi AmaliMatharaarachchi added trigger-action When this includes apk actions getting trigger for pr and removed trigger-action When this includes apk actions getting trigger for pr labels Sep 24, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Sep 24, 2024
@AmaliMatharaarachchi AmaliMatharaarachchi added the trigger-action When this includes apk actions getting trigger for pr label Sep 24, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Sep 25, 2024
@AmaliMatharaarachchi AmaliMatharaarachchi added the trigger-action When this includes apk actions getting trigger for pr label Sep 25, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Sep 25, 2024
@AmaliMatharaarachchi AmaliMatharaarachchi added the trigger-action When this includes apk actions getting trigger for pr label Sep 25, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Sep 25, 2024
@AmaliMatharaarachchi AmaliMatharaarachchi added the trigger-action When this includes apk actions getting trigger for pr label Sep 25, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Sep 26, 2024
@AmaliMatharaarachchi AmaliMatharaarachchi added the trigger-action When this includes apk actions getting trigger for pr label Sep 26, 2024
@AmaliMatharaarachchi AmaliMatharaarachchi added trigger-action When this includes apk actions getting trigger for pr and removed trigger-action When this includes apk actions getting trigger for pr labels Sep 26, 2024
@AmaliMatharaarachchi
Copy link
Contributor Author

Closing as this is already sent in #2495

@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Sep 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.87%. Comparing base (707328a) to head (587bd93).
Report is 248 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2455      +/-   ##
==========================================
- Coverage   26.08%   18.87%   -7.22%     
==========================================
  Files          68      113      +45     
  Lines        4769    18700   +13931     
  Branches     2451        0    -2451     
==========================================
+ Hits         1244     3529    +2285     
- Misses       3525    14967   +11442     
- Partials        0      204     +204     
Flag Coverage Δ
adapter 18.87% <ø> (?)
config-deployer-service ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API gateway conformance tests
3 participants