Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete API Key support implementation #2402

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

sgayangi
Copy link
Contributor

Purpose

This PR adds the required field for API Key and supports the optionality of the authenticators similar to the APIM implementation.
Testing was done in CP to DP mode with an API Key generated from the APIM side.

Fixes #2399

@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Jul 18, 2024
@sgayangi sgayangi force-pushed the 2399-sgayangi-api-key branch from 7aca1bb to 73c88a8 Compare July 19, 2024 04:18
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Jul 19, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Jul 19, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Jul 19, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Jul 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.91%. Comparing base (707328a) to head (0d03540).
Report is 91 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2402      +/-   ##
==========================================
- Coverage   26.08%   19.91%   -6.18%     
==========================================
  Files          68      229     +161     
  Lines        4769    26206   +21437     
  Branches     2451     2723     +272     
==========================================
+ Hits         1244     5218    +3974     
- Misses       3525    20800   +17275     
- Partials        0      188     +188     
Flag Coverage Δ
adapter 20.44% <ø> (?)
common-controller 1.97% <ø> (?)
config-deployer-service 26.78% <ø> (+0.70%) ⬆️
idp-domain-service 80.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sgayangi sgayangi added trigger-action When this includes apk actions getting trigger for pr and removed trigger-action When this includes apk actions getting trigger for pr labels Jul 19, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Jul 22, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Jul 22, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Jul 22, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Jul 22, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Jul 23, 2024
@sgayangi sgayangi added trigger-action When this includes apk actions getting trigger for pr and removed trigger-action When this includes apk actions getting trigger for pr labels Jul 23, 2024
@sgayangi sgayangi force-pushed the 2399-sgayangi-api-key branch from 63812bf to 3603592 Compare July 24, 2024 04:04
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Jul 24, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Jul 24, 2024
@sgayangi sgayangi force-pushed the 2399-sgayangi-api-key branch from 3603592 to 7d9c7bb Compare July 24, 2024 04:51
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Jul 24, 2024
@sgayangi sgayangi added trigger-action When this includes apk actions getting trigger for pr and removed trigger-action When this includes apk actions getting trigger for pr labels Jul 24, 2024
@sgayangi sgayangi force-pushed the 2399-sgayangi-api-key branch from 7d9c7bb to 781a5d5 Compare August 6, 2024 14:24
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Aug 6, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Aug 6, 2024
@sgayangi sgayangi removed the trigger-action When this includes apk actions getting trigger for pr label Sep 2, 2024
@sgayangi sgayangi force-pushed the 2399-sgayangi-api-key branch from 781a5d5 to 85301e2 Compare September 4, 2024 12:56
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Sep 4, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Sep 4, 2024
@sgayangi sgayangi force-pushed the 2399-sgayangi-api-key branch from 85301e2 to 3f4f9ad Compare September 4, 2024 13:59
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Sep 4, 2024
@sgayangi sgayangi force-pushed the 2399-sgayangi-api-key branch from 3f4f9ad to 451ef7f Compare September 13, 2024 09:23
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Sep 13, 2024
@sgayangi sgayangi force-pushed the 2399-sgayangi-api-key branch from 451ef7f to ee40967 Compare September 13, 2024 09:41
@sgayangi sgayangi added trigger-action When this includes apk actions getting trigger for pr labels Sep 13, 2024
@sgayangi sgayangi force-pushed the 2399-sgayangi-api-key branch from ee40967 to cbfd4ec Compare September 18, 2024 04:37
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Sep 18, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Sep 18, 2024
@CrowleyRajapakse CrowleyRajapakse merged commit b911021 into wso2:main Sep 18, 2024
11 of 12 checks passed
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete API Key functionality
3 participants