Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing generate k8s resource default org name #2218

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

CrowleyRajapakse
Copy link
Contributor

Purpose

fixes #2217

@CrowleyRajapakse CrowleyRajapakse added the trigger-action When this includes apk actions getting trigger for pr label Apr 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.42%. Comparing base (9678fcb) to head (839dd54).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2218      +/-   ##
==========================================
+ Coverage   27.75%   28.42%   +0.67%     
==========================================
  Files         124      124              
  Lines       14692    14546     -146     
  Branches     2681     2681              
==========================================
+ Hits         4078     4135      +57     
+ Misses      10483    10274     -209     
- Partials      131      137       +6     
Flag Coverage Δ
adapter 28.46% <ø> (+1.13%) ⬆️
common-controller 4.07% <ø> (ø)
config-deployer-service 25.99% <ø> (ø)
idp-domain-service 80.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubudu538 pubudu538 self-requested a review April 1, 2024 06:15
@CrowleyRajapakse CrowleyRajapakse merged commit 8c48ca6 into wso2:main Apr 1, 2024
12 checks passed
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config Generator k8s resources generate set incorrect org name to CRs
3 participants