Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm templating issues #2006

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Fix helm templating issues #2006

merged 1 commit into from
Mar 8, 2024

Conversation

sgayangi
Copy link
Contributor

@sgayangi sgayangi commented Feb 15, 2024

Purpose

Fixes #1989

@sgayangi sgayangi changed the title Fix helm templating issues [DRAFT] Fix helm templating issues Feb 15, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Feb 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.95%. Comparing base (da658ff) to head (9e25499).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2006      +/-   ##
==========================================
- Coverage   28.00%   27.95%   -0.06%     
==========================================
  Files         124      124              
  Lines       14553    14582      +29     
  Branches     2672     2672              
==========================================
  Hits         4076     4076              
- Misses      10346    10375      +29     
  Partials      131      131              
Flag Coverage Δ
adapter 27.63% <ø> (-0.10%) ⬇️
common-controller 4.07% <ø> (+<0.01%) ⬆️
config-deployer-service 26.03% <ø> (ø)
idp-domain-service 80.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sgayangi sgayangi added trigger-action When this includes apk actions getting trigger for pr and removed trigger-action When this includes apk actions getting trigger for pr labels Feb 19, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Feb 29, 2024
@sgayangi sgayangi force-pushed the #1989-sgayangi branch 3 times, most recently from 7e5e80f to d53039c Compare March 6, 2024 11:18
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Mar 6, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 7, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Mar 7, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 7, 2024
@sgayangi sgayangi added trigger-action When this includes apk actions getting trigger for pr and removed trigger-action When this includes apk actions getting trigger for pr labels Mar 7, 2024
@sgayangi sgayangi changed the title [DRAFT] Fix helm templating issues Fix helm templating issues Mar 7, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 7, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Mar 7, 2024
@Krishanx92 Krishanx92 merged commit 171f4ac into wso2:main Mar 8, 2024
11 of 12 checks passed
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 8, 2024
@sgayangi sgayangi mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm install broken
3 participants