Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscriptionValidation toggling capability to apk-conf #1847

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

ashera96
Copy link
Contributor

@ashera96 ashera96 commented Nov 9, 2023

Purpose

Improvements done to the application and subscription support added via [1] are:

  • Add subscription validation toggling capability to apk-conf
  • Add subscription validation enable capability at Gateway level. If enabled at the Gateway level, all API invocations undergo subscription validation. If not enabled at global level, API level config is checked to decide whether or not API invocations should undergo subscription validation.

Related PRs

  1. Add Application and Subscription Support #1783

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efb1c39) 25.68% compared to head (0b564f7) 25.70%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1847      +/-   ##
==========================================
+ Coverage   25.68%   25.70%   +0.01%     
==========================================
  Files         134      134              
  Lines       15100    15105       +5     
  Branches     2453     2454       +1     
==========================================
+ Hits         3879     3882       +3     
- Misses      11090    11092       +2     
  Partials      131      131              
Flag Coverage Δ
adapter 26.23% <ø> (-0.01%) ⬇️
common-controller 2.48% <ø> (ø)
config-deployer-service 28.43% <ø> (+0.05%) ⬆️
idp-domain-service 80.18% <ø> (ø)
router ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashera96 ashera96 force-pushed the app-sub-implementation branch from 0eccacf to ef36e45 Compare November 9, 2023 04:32
@tharindu1st tharindu1st merged commit 723c9b4 into wso2:main Nov 13, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants