Add scopes to the config ds #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chashikajw
force-pushed
the
add-scopes-config-ds
branch
from
1f6208a to
024dbb9
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1821 +/- ##
==========================================
+ Coverage 25.99% 26.00% +0.01%
==========================================
Files 250 125 -125
Lines 29534 14769 -14765
Branches 4894 2447 -2447
==========================================
- Hits 7678 3841 -3837
+ Misses 21594 10797 -10797
+ Partials 262 131 -131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chashikajw
force-pushed
the
add-scopes-config-ds
branch
7 times, most recently
from
7170fe8 to
bdf318b
Compare
chashikajw
force-pushed
the
add-scopes-config-ds
branch
from
bdf318b to
aa52aa4
Compare
Krishanx92
reviewed
Oct 17, 2023
helm-charts/templates/data-plane/config-deployer/config-deploy-api-scope1.yaml
Outdated
Show resolved
Hide resolved
Krishanx92
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR will add the apl:api_create scopes to the config deployer service
Fixes