Template admin interface port #1759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tharsanan1
force-pushed
the
template-admin-interface
branch
from
209399e to
9dc0d7a
Compare
added 2 commits
September 26, 2023 09:32
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1759 +/- ##
=======================================
Coverage 25.56% 25.56%
=======================================
Files 131 131
Lines 15163 15163
Branches 2561 2561
=======================================
Hits 3876 3876
Misses 11156 11156
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pubudu538
reviewed
Oct 2, 2023
| @@ -151,6 +151,7 @@ A Helm chart for APK components | |||
| | wso2.apk.dp.gatewayRuntime.deployment.router.strategy | string | `"RollingUpdate"` | Deployment strategy | | |||
| | wso2.apk.dp.gatewayRuntime.deployment.router.imagePullPolicy | string | `"Always"` | Image pull policy | | |||
| | wso2.apk.dp.gatewayRuntime.deployment.router.image | string | `"wso2/router:1.0.0"` | Image | | |||
| | wso2.apk.dp.gatewayRuntime.deployment.router.adminInterfaceEnabled | bool | `true` | Envoy proxy admin interface enabled or not | | |||
There was a problem hiding this comment.
We dont need this config. Added a comment in here - wso2/docs-apk#382 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose