[TM-1386] update reports statuses #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wri-terramatch-api into fix/TM-1104-fix-pitch-model
[TM-1144] add validation for null extra info
[TM-1144] reorder functions to get valid schema data for polygons
[TM-1146] Fix Pitch model if organization is null
* [TM-1136] feat: add logic to upload replacement polygons * [TM-1136] fix * [TM-1136] fix
Fix/tm 1123 remove decimals
* [TM-1136] fix: reassigning site uuid * [TM-1136] fix * [TM-1136] fix * [TM-1136] fix test * [TM-1136] fix lint * [TM-1136] fix lint * [TM-1136] fix lint
* [TM-1104] send project_pitch_uuid for submisssion * [TM-1104] update swagger definition for project pitch uuid * [TM-1104] update swagger definition for project pitch uuid * [TM-1104] make lint fix --------- Co-authored-by: JORGE <[email protected]>
* [TM-1179] revert approved on update geom * [TM-1179] change status on edit to model
* [TM-1179] on save attributes change to submitted if approved
…quat' into TM-778
[TM-778] issue searching site reports by site name
[TM-1106] Improved long term scheduling system.
* [TM-1366] insert landscape data, create seeder and migration * [TM-1366] add fix lint
* [TM-1479] changes columns to table indicators * changes indicator_id to indicator_slug in controller
…terramatch-api into feat/TM-1127-add-worker
…rise Reporting Tasks (#526) * [TM-1353] add OneOff command to seed hbf and enterprises reports * remove imports * update hours for to account for tz displacement * update name * add one-off command for backdated reports * fix typo
* [TM-1479] changes columns to table indicators * changes indicator_id to indicator_slug in controller * [TM-1379] change indicator_slug values
[TM-1127] Add worker
cesarLima1
previously approved these changes
Oct 31, 2024
roguenet
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Two thing:
- This would be better implemented as a Command than a seeder, as it more conceptually aligns with what this tool is doing. Seeders are for getting initial data into a table, not for modifications
- I don't think the .csv makes much sense to check in. Would be better to just upload to the EC2 box and pass it as an argument to the command.
BulkWorkdayImport is an example of a Command that works in this way.
…ri-terramatch-api into feat/TM-1386-bulk-approved
roguenet
reviewed
Nov 1, 2024
roguenet
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a command that will update via projects projectReport, siteReport and tasks from
“awaiting approval” or “needs more information” to “approved”.