Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #72 #72

Closed
wants to merge 3 commits into from
Closed

closes #72 #72

wants to merge 3 commits into from

Conversation

gardenboi
Copy link
Collaborator

This is the feature that adds a custom field to the honeyform settings to exclude specific pages with a nice and simple UI, this feature was originally requested by @linuxlurak in the #40

@gardenboi gardenboi added the enhancement New feature or request label Nov 25, 2023
@gardenboi gardenboi changed the title closes #71 closes #72 Nov 25, 2023
@gardenboi gardenboi changed the title closes #72 closes #71 Nov 25, 2023
@gardenboi gardenboi changed the title closes #71 closes #72 Nov 25, 2023
@gardenboi
Copy link
Collaborator Author

For the commit 5935e2c
The eslint test:

  eslint:
    name: runner / eslint

logged an error related to browser-list that required the update of browser list as the devs have noted in their repo.

So then i updated, had a CRLF issure so I added gitattributes as a fallback

Finally I added the following to .eslint.js

  rules: {
    'no-console': 'off',
  }

has logged a no-console error, by checking our codebase I found that inside
cft7-antispam/vendor/squizlabs/php_codesniffer/src/Standards/Squiz/Tests/Commenting/InlineCommentUnitTest.js
there are some test that explicitly run console.log() as part of the test.
maybe there is a way to exclude specific paths.

I think the browser-list update broke Node v14.0 tests so I ask you how to proceed, should we revert back to the initial commit and change the test is build.yml ?

let me know @erikyo

This reverts commit 5d375c0.
@erikyo
Copy link
Collaborator

erikyo commented Nov 25, 2023

@gardenboi I believe the issue is related to the console.log("2") that you can find src/settings/settings.js and correctly eslint is returning a warning for that. The solution is simply to remove that console.log and not to change the eslint rules.

@gardenboi gardenboi force-pushed the honeyform/exception-list-setting branch from 6c261b8 to 722763a Compare November 25, 2023 21:34
@gardenboi gardenboi closed this Nov 25, 2023
@gardenboi gardenboi deleted the honeyform/exception-list-setting branch November 25, 2023 21:45
gardenboi added a commit that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants