Applied suggestions from code review

-Added translations to select field on buttons -Changed css: added margin, removed <br> in the select field, changged color nomenclature from hex to literal - Co-authored-by: Erik Golinelli <[email protected]>
wp-blocks · Nov 26, 2023 · 7119f5b · 7119f5b
1 parent 395f3ef
commit 7119f5b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/admin/CF7_AntiSpam_Admin_Customizations.php b/admin/CF7_AntiSpam_Admin_Customizations.php
@@ -1506,20 +1506,20 @@ public function cf7a_honeyform_excluded_pages_callback() {
 								<select name="add" multiple class="form-control add-select">
 								  %s
 								</select>
-								<br/>
-								<div class="add-list">Add ></div>
+								<div class="honeyform-action add-list">%s ></div>
 							  </div>
 							  <div class="remove">
 								<select id="honeyform_excluded_pages" name="cf7a_options[honeyform_excluded_pages][]" multiple="multiple" class="form-control remove-select" >
 								%s
 								</select>
-								<br/>
-								<div class="remove-list">< Remove</div>
+								<div class="honeyform-action remove-list">< %s</div>
 							  </div>
 						 </div>
 					 </div>',
 					$options,
-					$str_excluded
+					__( 'Add', 'cf7-antispam' ),
+					$str_excluded,
+					__( 'Remove', 'cf7-antispam' ),
 		);
 	}
 

diff --git a/src/settings/settings.scss b/src/settings/settings.scss
@@ -95,6 +95,10 @@ $color__info: $color__blue;
 			display: flex;
 			flex-wrap: wrap;
 
+			.honeyform-action {
+				margin-top: 8px;
+			}
+
 			.add,
 			.remove {
 				flex: 1;
@@ -104,7 +108,7 @@ $color__info: $color__blue;
 				}
 				div {
 					text-align: center;
-					border: #8c8f94 solid 1px;
+					border: $color__dark-grey solid 1px;
 				}
 			}
 		}