test(integration): extending entity class to avoid reusing it

wovalle · Oct 19, 2019 · 7c069f5 · 7c069f5
1 parent 0dc257a
commit 7c069f5
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/src/Decorators/SubCollection.spec.ts b/src/Decorators/SubCollection.spec.ts
@@ -13,12 +13,12 @@ describe('SubCollectionDecorator', () => {
   it('should register collections', () => {
     class SubEntity {}
     class Entity {
-      @SubCollection(SubEntity, 'subentities')
+      @SubCollection(SubEntity, 'subs')
       readonly subentity: null;
     }
 
     expect(store.metadataStorage.subCollections.length).to.eql(1);
-    expect(store.metadataStorage.subCollections[0].name).to.eql('subentities');
+    expect(store.metadataStorage.subCollections[0].name).to.eql('subs');
     expect(store.metadataStorage.subCollections[0].parentEntity).to.eql(Entity);
     expect(store.metadataStorage.subCollections[0].entity).to.eql(SubEntity);
     expect(store.metadataStorage.subCollections[0].propertyKey).to.eql(

diff --git a/test/BandCollection.ts b/test/BandCollection.ts
@@ -1,8 +1,17 @@
 import { Collection, SubCollection } from '../src/Decorators';
-import { Album, Coordinates } from './fixture';
+import { Album as AlbumEntity, Coordinates } from './fixture';
 import { ISubCollection } from '../src/types';
 import { Type } from '../src';
 
+// Why I do this? Because by using the instance of Album
+// located in fixture.ts, you have the risk to reuse the
+// same class in many tests and every method that depends
+// in the instance of the class being unique might clash
+// with each other (happened with GetRepository)
+//
+// Hours lost debugging this: 2
+class Album extends AlbumEntity {}
+
 @Collection('bands')
 export class Band {
   id: string;

diff --git a/test/functional/3-subcollections.spec.ts b/test/functional/3-subcollections.spec.ts
@@ -1,4 +1,8 @@
-import { Band, Album, getInitialData } from '../fixture';
+import {
+  Band as BandEntity,
+  Album as AlbumEntity,
+  getInitialData,
+} from '../fixture';
 import {
   GetRepository,
   Collection,
@@ -9,8 +13,10 @@ import { getUniqueColName } from '../setup';
 import { expect } from 'chai';
 
 describe('Integration test: SubCollections', () => {
+  class Album extends AlbumEntity {}
+
   @Collection(getUniqueColName('band-with-subcollections'))
-  class FullBand extends Band {
+  class FullBand extends BandEntity {
     @SubCollection(Album)
     albums: ISubCollection<Album>;
   }