Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AnimatedImageCache and related types #23926

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Dec 24, 2024

Both AnimatedImageCache and AuthenticatedImageDownload were already using new ImageDownloader infrastructure under the hood, so it was just a matter of removing the indirection.

Changes

  • Update EditorMediaUtility to use ImageDownloader directly (without AuthenticatedImageDownload redirect)
  • Remove AuthenticatedImageDownload
  • Update MediaExternalExporter to use ImageDownloader for downloading GIF data
  • Remove AnimatedImageCache

To test:

  • Verify that image are loaded in the editor
  • Verify that adding GIFs from an external source works (see recording for steps)

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Media label Dec 24, 2024
@kean kean added this to the 25.7 milestone Dec 24, 2024
@kean kean merged commit f09a0cd into christmas-feature-branch Dec 24, 2024
3 of 17 checks passed
@kean kean deleted the task/remove-animated-image-cache branch December 24, 2024 18:15
@kean kean mentioned this pull request Dec 24, 2024
14 tasks
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23926-0136de2
Version25.6
Bundle IDorg.wordpress.alpha
Commit0136de2
App Center BuildWPiOS - One-Offs #11231
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23926-0136de2
Version25.6
Bundle IDcom.jetpack.alpha
Commit0136de2
App Center Buildjetpack-installable-builds #10269
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants