Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade GutenbergKit #23919

Merged
merged 2 commits into from
Dec 23, 2024
Merged

build: Upgrade GutenbergKit #23919

merged 2 commits into from
Dec 23, 2024

Conversation

dcalhoun
Copy link
Member

Upgrade GutenbergKit.

To test: Smoke test the experimental editor.

Regression Notes

  1. Potential unintended areas of impact
    Unlikely given the narrow focus.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    No testing performed.
  3. What automated tests I added (or what prevented me from doing so)
    Deemed unnecessary for this dependency upgrade.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dcalhoun dcalhoun added [Type] Enhancement Gutenberg Editing and display of Gutenberg blocks. labels Dec 20, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 20, 2024

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@dcalhoun dcalhoun marked this pull request as ready for review December 20, 2024 21:56
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 20, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23919-4bf280a
Version25.6
Bundle IDorg.wordpress.alpha
Commit4bf280a
App Center BuildWPiOS - One-Offs #11223
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 20, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23919-4bf280a
Version25.6
Bundle IDcom.jetpack.alpha
Commit4bf280a
App Center Buildjetpack-installable-builds #10261
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dcalhoun dcalhoun requested a review from kean December 20, 2024 22:14
@dcalhoun dcalhoun enabled auto-merge December 20, 2024 22:14
@kean
Copy link
Contributor

kean commented Dec 23, 2024

I can't wait to ship this 👏

@dcalhoun dcalhoun added this pull request to the merge queue Dec 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 23, 2024
@kean kean added this pull request to the merge queue Dec 23, 2024
Merged via the queue into trunk with commit 3900198 Dec 23, 2024
25 checks passed
@kean kean deleted the build/upgrade-gutenberg-kit branch December 23, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants