Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-publishing sheet: Fix typo #22656

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

momo-ozawa
Copy link
Contributor

@momo-ozawa momo-ozawa commented Feb 21, 2024

Fixes a typo in the pre-publishing sheet

How to test

  • Verify the pre-publishing sheet displays "PUBLISHING TO" instead of "CLOSE"

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented Feb 21, 2024

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 21, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22656-a3ebe2f
Version24.3
Bundle IDorg.wordpress.alpha
Commita3ebe2f
App Center BuildWPiOS - One-Offs #8894
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 21, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22656-a3ebe2f
Version24.3
Bundle IDcom.jetpack.alpha
Commita3ebe2f
App Center Buildjetpack-installable-builds #7924
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@momo-ozawa momo-ozawa requested a review from kean February 21, 2024 12:26
@momo-ozawa momo-ozawa merged commit ff61a0d into release/24.3 Feb 21, 2024
22 of 25 checks passed
@momo-ozawa momo-ozawa deleted the fix/prepublishing-string branch February 21, 2024 14:58
@momo-ozawa
Copy link
Contributor Author

FYI @mokagio - can you assist us in merging the release branch into trunk, so the .strings changes get uploaded to GlotPress?

Thank you btw for your detailed instructions on how to update strings after code freeze! (p1707777814158979/1707751740.216079-slack-C02AED43D)

@mokagio
Copy link
Contributor

mokagio commented Feb 22, 2024

@momo-ozawa sure thing. 🙌

@mokagio
Copy link
Contributor

mokagio commented Feb 22, 2024

@momo-ozawa this is now done #22665

I'll start a beta tomorrow, once the .strings changes reach GlotPress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants