Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StatsSubscribersAccessed analytics event #356

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Add StatsSubscribersAccessed analytics event #356

merged 2 commits into from
Apr 21, 2024

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Apr 19, 2024 •
edited
Loading

Related PR: wordpress-mobile/WordPress-iOS#23040
Add StatsSubscribersAccessed analytics event

  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@staskus staskus mentioned this pull request Apr 19, 2024
Merged
14 tasks
@staskus staskus requested a review from guarani April 19, 2024 11:33
guarani
guarani approved these changes Apr 19, 2024
View reviewed changes
Copy link

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I think at some point we should move all the events over to WPAnalyticsEvent.swift, but that's out of scope here 😄

@staskus staskus merged commit 688ee5e into trunk Apr 21, 2024
9 checks passed
@staskus staskus deleted the task/subscribers-stats-analytics-event branch April 21, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guarani guarani guarani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staskus @guarani