Use Swift 5.10 toolchain #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`swift build` failed with: > error: the library 'WordPressShared' requires macos 10.13, but depends on the product 'SwiftLintPlugin' which requires macos 12.0; consider changing the library 'WordPressShared' to require macos 12.0 or later, or the product 'SwiftLintPlugin' to require macos 10.13 or earlier.
Generated by 🚫 Danger |
mokagio
force-pushed
the
mokagio/swift-5.10-toolchain
branch
from
1215cb6 to
8969098
Compare
crazytonyli
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawned from the conversation with @crazytonyli at #354 (comment)
The toolchain upgrade stands on its own, but the aim of this PR is to show that, unfortunately, the workaround from #354 is necessary for packages that use this as a dependency. See wordpress-mobile/WordPressKit-iOS#789
CHANGELOG.mdif necessary.